Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui-library): removed readonly state for checkbox radio radiogroup and toggle switch #1167

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix(ui-library): removed readonly state for checkbox radio radiogroup and toggle switch #1167

wants to merge 2 commits into from

Conversation

ashk1996
Copy link
Contributor

@ashk1996 ashk1996 commented Oct 2, 2024

Removed readonly state and css for the above components

thrbnhrtmnn
thrbnhrtmnn approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@thrbnhrtmnn thrbnhrtmnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashk1996 , PR looks good to me, before merging, we also need to do the design changes. Please contact @larserbach for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrbnhrtmnn thrbnhrtmnn thrbnhrtmnn approved these changes

@larserbach larserbach Awaiting requested review from larserbach

@bar-tay bar-tay Awaiting requested review from bar-tay

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashk1996 @thrbnhrtmnn